RTL8139/RTL8168 driver #504
Conversation
| * This class serves to encapsulate the peculiarities of queue indices, especially their | ||
| * wrap-around modular arithmetic. | ||
| */ | ||
| struct QueueIndex { |
There was a problem hiding this comment.
This seems like something that is better suited to maybe put in frigg?
There was a problem hiding this comment.
this seems like it's part of a more general ring buffer style container
There was a problem hiding this comment.
Yeah it also seems like it's used this way in the code. Might be cleaner to just use a straight up ring-buffer container.
| struct TxQueue { | ||
| TxQueue(size_t descriptors, RealtekNic &nic); | ||
|
|
||
| virtual ~TxQueue() = default; |
There was a problem hiding this comment.
What's the need for this virtual destructor?
There was a problem hiding this comment.
gcc complains otherwise: warning: delete called on 'TxQueue' that is abstract but has non-virtual destructor
| struct RxQueue { | ||
| RxQueue(size_t descriptors, RealtekNic &nic); | ||
|
|
||
| uintptr_t getBase() { |
There was a problem hiding this comment.
If I make getBase constant, gcc complains about the operator[] method not being const.
There was a problem hiding this comment.
make that const too then :)
(rather, there needs to be two overloads)
|
Addressed the comments above and rebased on master. |
|
The driver is now capable of sending and receiving packets somewhat reliably on my revision of the RTL8168 card (MacVer46, rtl8168h). |
Depends on managarm/frigg#58.