Add dictionary c data integration tests #451
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #451 +/- ##
=======================================
Coverage 88.30% 88.30%
=======================================
Files 96 96
Lines 7302 7302
=======================================
Hits 6448 6448
Misses 854 854
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| // ); | ||
| // } | ||
| // } | ||
| // } |
There was a problem hiding this comment.
Why commenting this?
| @@ -40,8 +40,6 @@ namespace sparrow::c_data_integration | |||
| std::vector<sparrow::array> | |||
| get_children_arrays(const nlohmann::json& array, const nlohmann::json& schema, const nlohmann::json& root); | |||
|
|
|||
| void read_schema_from_json(const nlohmann::json& data); | |||
There was a problem hiding this comment.
Why dropping this one?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.