Skip to content

Integration tests list view #438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

Alex-PLACET
Copy link
Collaborator

No description provided.

@Alex-PLACET Alex-PLACET self-assigned this Jun 3, 2025
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.30%. Comparing base (b870e0a) to head (2fb372d).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #438      +/-   ##
==========================================
+ Coverage   88.22%   88.30%   +0.07%     
==========================================
  Files          96       96              
  Lines        7277     7301      +24     
==========================================
+ Hits         6420     6447      +27     
+ Misses        857      854       -3     
Flag Coverage Δ
unittests 88.30% <100.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Alex-PLACET Alex-PLACET requested a review from JohanMabille June 3, 2025 08:38
@Alex-PLACET Alex-PLACET force-pushed the integration_tests_list_view branch from 4e1ad54 to 46463a9 Compare June 11, 2025 11:44
@Alex-PLACET Alex-PLACET requested a review from Copilot June 12, 2025 15:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces integration test modifications to support a new list view functionality. Key changes include updating the test file with additional JSON test cases, adding new utility functions (get_offsets and get_sizes) and a list view parser with associated JSON parser mappings, and updating build and metadata files accordingly.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
test/c_data_integration/test_c_data_integration/test_c_data_integration.cpp Updated test cases list with additional JSON files for integration tests.
test/c_data_integration/src/utils.cpp Added new functions get_offsets and get_sizes to extract offset and size arrays.
test/c_data_integration/src/listview_parser.cpp Introduced list view array builders for standard and large list views.
test/c_data_integration/src/json_parser.cpp Registered new list view related array builder functions.
test/c_data_integration/include/sparrow/c_data_integration/utils.hpp Declared get_offsets and get_sizes functions.
test/c_data_integration/include/sparrow/c_data_integration/listview_parser.hpp Added new header for list view parser declarations.
test/c_data_integration/include/sparrow/c_data_integration/constant.hpp Added SIZE constant definition.
test/c_data_integration/CMakeLists.txt Updated project build with new listview_parser source.
include/sparrow/utils/metadata.hpp Minor update to loop variable usage.
.github/workflows/qemu.yaml Updated Alpine branch version to v3.22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant