-
Notifications
You must be signed in to change notification settings - Fork 19
Integration tests list view #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Integration tests list view #438
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #438 +/- ##
==========================================
+ Coverage 88.22% 88.30% +0.07%
==========================================
Files 96 96
Lines 7277 7301 +24
==========================================
+ Hits 6420 6447 +27
+ Misses 857 854 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4e1ad54
to
46463a9
Compare
test/c_data_integration/test_c_data_integration/test_c_data_integration.cpp
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR introduces integration test modifications to support a new list view functionality. Key changes include updating the test file with additional JSON test cases, adding new utility functions (get_offsets and get_sizes) and a list view parser with associated JSON parser mappings, and updating build and metadata files accordingly.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
test/c_data_integration/test_c_data_integration/test_c_data_integration.cpp | Updated test cases list with additional JSON files for integration tests. |
test/c_data_integration/src/utils.cpp | Added new functions get_offsets and get_sizes to extract offset and size arrays. |
test/c_data_integration/src/listview_parser.cpp | Introduced list view array builders for standard and large list views. |
test/c_data_integration/src/json_parser.cpp | Registered new list view related array builder functions. |
test/c_data_integration/include/sparrow/c_data_integration/utils.hpp | Declared get_offsets and get_sizes functions. |
test/c_data_integration/include/sparrow/c_data_integration/listview_parser.hpp | Added new header for list view parser declarations. |
test/c_data_integration/include/sparrow/c_data_integration/constant.hpp | Added SIZE constant definition. |
test/c_data_integration/CMakeLists.txt | Updated project build with new listview_parser source. |
include/sparrow/utils/metadata.hpp | Minor update to loop variable usage. |
.github/workflows/qemu.yaml | Updated Alpine branch version to v3.22. |
test/c_data_integration/test_c_data_integration/test_c_data_integration.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <[email protected]>
…tegration.cpp Co-authored-by: Copilot <[email protected]>
for more information, see https://pre-commit.ci
Co-authored-by: Copilot <[email protected]>
No description provided.