Add Pronatura Bydgoszcz #2138
Open
Add Pronatura Bydgoszcz #2138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please provide a md file and run the updatedoculinks.py script like described in the Source Contribution Guide |
5ila5
reviewed
Jun 12, 2024
Comment on lines
+55
to
+59
| try: | ||
| return self.get_data() | ||
| except Exception as e: | ||
| _LOGGER.error(f"fetch failed for source {TITLE}: {e}") | ||
| return [] |
There was a problem hiding this comment.
Please do not catch any errors, they will be caught automatically
Comment on lines
+102
to
+120
| if waste_type in ["papier", "plastik", "szkło"]: | ||
| recykling_days.add(int(day)) | ||
| else: | ||
| entries.append( | ||
| Collection( | ||
| datetime.date(year, month, int(day)), | ||
| name_map[waste_type], | ||
| ICON_MAP[waste_type], | ||
| ) | ||
| ) | ||
| # Add recykling entries | ||
| for day in recykling_days: | ||
| entries.append( | ||
| Collection( | ||
| datetime.date(year, month, day), | ||
| name_map["papier"], | ||
| "mdi:recycle", | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Is there a reason you are mapping paper plastic and glass to recycling instead of showing all 3. Are they always at the same date? For all addresses?
5ila5
reviewed
Jun 12, 2024
|
|
||
| TITLE = "Bydgoszcz Garbage Collection" | ||
| DESCRIPTION = "Source for Bydgoszcz city garbage collection by Pronatura" | ||
| URL = "https://zs5cv4ng75.execute-api.eu-central-1.amazonaws.com/prod" |
There was a problem hiding this comment.
URL is used by the updatedoculinks.py script and will be shown in the README.md use the website URL here instead and rename this variable to something like API_URL
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pronatura Bydgoszcz serves a part of Bydgoszcz, Poland
Paper / Plastics / Glass is always on the same they so they are combined into Recycling