Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing problem where organic isn't shown properly #1362

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aaronpowell
Copy link
Contributor

Fixes #1361

@5ila5
Copy link
Collaborator

5ila5 commented Oct 28, 2023

Did some digging myself and found:

  • first two test cases seem to be no longer work and addresses are not listed on their website (change street number (810 -> 813, 599 -> 597)
  • this approach of seems to only work on address where garbage and recycling collections are not at the same day (like 597 Darling Street ROZELLE) and ignores organic collections on addresses where garbage and recycling are on the same day (like 29 Lackey Street SUMMER HILL)

Maybe you can check if there is a better approach to this. I noticed that we get the collection dates differently than the web page. maybe we should use the API the website uses to populate the calendar.

edit:
I would also like to raise an exception instead of returning [] so that uses have at least something in their logs instead of just not getting any data

@aaronpowell
Copy link
Contributor Author

Thanks @5ila5 I'll look into those problems.

Didn't realise how much of a variance there is in our local area on the waste pickups...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weekly organic collection not shown
2 participants