Refactor Nottingham City to pull only one date per bin type (#3353)

* Refactor Nottingham City to pull only one date per bin type

Nottingham City API sometimes give multiple dates for bins, particularly just after collection date. Locally, it makes sense to only use the smallest of these dates as we want the NEXT collection only.

* Simplify second if statement into min and update comment

* Simplify checks to just filter out collecions further ahead than a year

* Minimize net changes

custom_components/waste_collection_schedule/waste_collection_schedule/source/nottingham_city_gov_uk.py

@@ -39,15 +39,19 @@ def fetch(self):
 
         next_collections = data["nextCollections"]
 
+        # Sometimes the Nottingham City Council API returns collections
+        # far in the future, so let's only consider the next 12 months
+
         for collection in next_collections:
             bin_type = collection["collectionType"]
-
             props = BINS[bin_type]
-
             next_collection_date = datetime.datetime.fromisoformat(
                 collection["collectionDate"]
             )
 
+            if next_collection_date > datetime.datetime.now() + datetime.timedelta(years=1):
+                continue
+
             entries.append(
                 Collection(
                     date=next_collection_date.date(),