cpu/upd7725.cpp: Fix naming for host interface function, Suppress side effects for debugger reads #13530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e effects for debugger reads NEC DSPs are not just for SNES cartridges, but also used at SSV arcade system and Prose 2000/2020 card.
|
I would suggest instead splitting the 'host_r' and 'host_w' functions into 'data_r' and 'data_w' plus 'status_r' (there isn't a 'status_w' on the real device except for some unimportant test mode stuff). (I already have a local change to do this, as part of a much larger retooling of the upd7725) |
bus/snes/upd.cpp, seta/ssv.cpp: Simplify DSP Data RAM accessing functions
Done since 1d45fa7 . |
cuavas
reviewed
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NEC UPD7725/UPD96050 DSPs are not just for SNES cartridges, but also used at SSV arcade system and Prose 2000/2020 card.