[Feature] MVP 익스텐션 패키지 기능 구현 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hin6150
approved these changes
Jun 9, 2024
Comment on lines
47
to
92
| export const SearchWindowHeader = styled.div` | ||
| display: flex; | ||
| align-items: center; | ||
| justify-content: space-between; | ||
| position: relative; | ||
|
|
||
| margin-bottom: 16px; | ||
|
|
||
| .term-header { | ||
| display: flex; | ||
| align-items: center; | ||
| width: 100%; | ||
|
|
||
| img { | ||
| width: 22px; | ||
| height: 22px; | ||
| margin-right: 6px; | ||
| transform: translateY(-2px); | ||
| } | ||
|
|
||
| p { | ||
| font-size: 14px; | ||
| font-weight: 700; | ||
| line-height: 1.2; | ||
|
|
||
| &.query { | ||
| display: block; | ||
| max-width: 50%; | ||
|
|
||
| text-overflow: ellipsis; | ||
| overflow: hidden; | ||
| white-space: nowrap; | ||
| } | ||
|
|
||
| &.tail { | ||
| margin-left: 3px; | ||
| } | ||
| } | ||
| } | ||
|
|
||
| button { | ||
| position: absolute; | ||
| top: 0; | ||
| right: 0; | ||
| } | ||
| ` |
There was a problem hiding this comment.
SearchWindowHeader.styles.tsx이 별도로 파일로 있는데, 일부로 중복으로 둔건가용?
There was a problem hiding this comment.
그리고, 해당 리스트 컴포넌트를 익스텐션이랑 웹이랑 공동으로 사용하지 않으면 좀 더 단순한 구조로 수정해도 좋을 것 같습니다 !
사용하지 않으면 추후에 제가 수정해둘게용
packages/design-system/src/components/List
There was a problem hiding this comment.
- 앗 컴포넌트 분리 이후에 스타일 제거하는걸 까먹고 있었네요 수정하겠습니다!
- 지금 UI 라이브러리를 번들링해서 익스텐션에도 사용할 수 있을지 확인해보고 있어서 해당 경우는 일단 놔두셔도 괜찮을 것 같습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Overview
chrome-extension에서extension으로 변경Additional Comment
기존에
vite+crx를 통해 개발하다가 크로스 브라우징을 지원하는plasmo프레임워크로 변경하였습니다.단점으로는
vanilla extract의 번들 패키지를 적용할 방법을 아직 못찾아서plasmo공식문서에서 추천하는emotion cache를 사용하였습니다.Issue
Check List
References