[Feature] 디자인 시스템 기반 컴포넌트 이어서 작업 #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cobocho
reviewed
May 20, 2024
| it('Icon은 정상적으로 렌더링 된다.', () => { | ||
| render(<Icon />) | ||
|
|
||
| expect(screen.getByText('Icon')).toBeInTheDocument() |
There was a problem hiding this comment.
P3: 이미지의 경우 getByAltText 쿼리를 통해 테스트 할 수 있습니다
Comment on lines
7
to
9
| render(<List>Text</List>) | ||
|
|
||
| expect(screen.getByText('List')).toBeInTheDocument() |
There was a problem hiding this comment.
P2: 실제 children과 테스트 쿼리가 달라서 테스트가 깨지는 것 같아요!
Comment on lines
+8
to
+9
| variant?: 'page' | 'search' | ||
| kind?: 'table' | 'synonym' | 'description' | 'title' |
There was a problem hiding this comment.
P4: css.ts에서 만든 ListVariants를 활용할 수도 있을 것 같아요!
There was a problem hiding this comment.
List Props으로 ListVariants를 가져오면 와 같이 사용할 수 있는데, 이 경우에는 사용자가 page와 search 두가지 경우 모두를 입력할 수 있게 되어서 구현에 어려움이 있었습니다.
keyof ListVariants으로 key 값을 가져오려고 해도 undefined가 붙어서 그런지 string은 never 형식에 사용할 수 없다는 type 에러가 발생합니다 ㅠㅠ
혹시 제가 놓치고 있는 부분이 있는 것이면 알려주세요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Overview
Additional Comment
Issue
#7
Check List
References