This repository was archived by the owner on Apr 18, 2023. It is now read-only.
Allow failures and return the hash along with the number #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests have not been updated to match and so are failing.
|
This needs tests for the new functions. |
|
Oops. Should have done this on a branch. |
sambacha
pushed a commit
to sambacha/multicall
that referenced
this pull request
May 5, 2022
* ⚙️ Multicall3 First Draft (#1) * ⚙️ multicall v3 * 🚧 add multicall3 section to the readme * forge install: solmate * forge install: forge-std * 🚧 foundry multicall testing * ⚙️ multicall2 🧪 * 🎨 design >> * 🚧 multicall3 backwards-compatibility and aggregate3 testing * 🚧 improve the foundry config toml * 🧪 extreme fuzzing ci profile * 🚧 add readme note for pragma changes * ⚙️ length and loop optimization * 🎨 clean up multi-line splits * 🎨 styling and remove cache * 🎨 clean up gitignore * ⚙️ remove solmate sorry t11s :sadblob: * 🎉 assert specificity * 🎨🐛 fix logo markdown rendering * 🎨🐛 fix logo markdown rendering * chore: config cleanup + fix solc version + increase optimizer runs * style: add space before parentheses in for statements * test: replace solidity assert with DSTest assertTrue * chore: remove unused files + move remappings to config file * ci: fix tests * ⚙️ t11s working improvement branch * 🚧 cleaning for merge * chore: change memory params to calldata for gas savings * chore: a bit of cleanup/revert string tweaks * chore: update gas snapshots * docs: update README Co-authored-by: Matt Solomon <[email protected]> * ⚙️ Community Suggestions (makerdao#3) * ⚙️ optimize aggregate * 🚧 pointer optimization * build: change method from view to pure per compiler warning Co-authored-by: Matt Solomon <[email protected]> * 🛢️ Payable Gas Reductions (makerdao#4) * ⚙️ make functions payable * :gas: gas snapshot * ⚙️ payable dev note at top of contract * 💰 Aggregate3Value (makerdao#5) * 🚧 aggregate3value and docs * Update src/Multicall3.sol Co-authored-by: Matt Solomon <[email protected]> * ⚙️ spacing * 🚧 specified fixes * ⚙️ fix accumulator Co-authored-by: Matt Solomon <[email protected]> * 🚧 Finishing Touches (makerdao#6) * 🚧 finalize multicall3 pr * ⚙️ optimize call value pointer * ⚙️ addition accessors * 🚧 remove misc from agg3 * ⚙️ failing to revert * wip: fix parsing of data, but foundry not catching assembly revert? * stash * 🚧 remove outdated gas 💩 * 🚑 add to gitignore 🔒 * feat: save gas in aggregate3Value * chore: update revert strings for consistency/clarity * ❌ Remove Brewfile * docs: update docs * docs: update comments Co-authored-by: Matt Solomon <[email protected]> * chore: update docs * feat: gas savings * docs: make comments more concise * 🔨 bad calls length ref * chore/docs: some cleanup * docs: add deploys Co-authored-by: abigger87 <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes I'm aggregating calls and I expect some failures. This lets me aggregate them.
Returning the block hash helps me in the event of a re-org.