Skip to content
This repository was archived by the owner on Apr 18, 2023. It is now read-only.

Add deprecation notice #45

Merged
merged 4 commits into from
Mar 2, 2023
Merged

Add deprecation notice #45

merged 4 commits into from
Mar 2, 2023

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Apr 20, 2022

This repository has been great, and I've relied on these Multicall contracts many times over the past few years. However, it appears this repo is no longer be maintained, as there are open issues and pull requests that have not been addressed for over a year.

As a result we've written an updated Multicall contract that is backwards-compatible with these versions, deployed it at the same address on 35 chains, and continue to perform new deploys as requested for other chains. This repo can be found at https://github.com/mds1/multicall.

New issues and PRs are still opened on this repository as it's easier to find than the above fork, so to help users I think it would be great to:

  • Mark this repo deprecated in the README and point to the updated fork
  • Prepend [DEPRECATED] to the repo description
  • Optionally, archive the repo so it's read only.

Copy link
Contributor

@gbalabasquer gbalabasquer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@brianmcmichael brianmcmichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️

README.md Outdated
@@ -1,3 +1,7 @@
# DEPRECATED

_This repository is no longer maintained. An active version can be found at https://github.com/mds1/multicall. Note that this is an external repository not maintained by the MakerDAO Protocol Engineering Core Unit._

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe fork sounds more separate?

Suggested change
_This repository is no longer maintained. An active version can be found at https://github.com/mds1/multicall. Note that this is an external repository not maintained by the MakerDAO Protocol Engineering Core Unit._
_This repository is no longer maintained. An active fork can be found at https://github.com/mds1/multicall. Note that this is an external repository not maintained by the MakerDAO Protocol Engineering Core Unit._

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea agreed, it does. Just updated!

Copy link

@iamchrissmith iamchrissmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

adding ✔️ since i commented - thanks!

Copy link

@godsflaw godsflaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

R.I.P. old girl

@gbalabasquer gbalabasquer merged commit 103a8a2 into makerdao:master Mar 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants