Lockstake V2 (only SKY) #64
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
telome
reviewed
Mar 19, 2025
oldchili
reviewed
Mar 19, 2025
oldchili
reviewed
Mar 19, 2025
telome
reviewed
Mar 19, 2025
oldchili
reviewed
Mar 19, 2025
oldchili
reviewed
Mar 20, 2025
oldchili
reviewed
Mar 25, 2025
telome
reviewed
Mar 26, 2025
| The first path requires the migrator to be `hope`d in the old Engine for the `urn` being migrated. An authed address needs to call this `hope` function previously. It is also required that the caller of `migrate` be an authed address in the `urn` being migrated and in the recipient one. | ||
| For the second path, apart from the same requirements of the simplest one, it is also necessary that an authed address in the `urn` that is receiving the position in the new Lockstake has `hope`d the migrator. | ||
|
|
||
| Note: The caller authed requirement for the recipient `urn` in the first path is just an extra safety measure to avoid migrating collateral to an undesired `urn`. However for the second path is indeed mandatory as migrating debt can convert the recipient `urn` to another type of risk exposure. |
There was a problem hiding this comment.
Suggested change
| Note: The caller authed requirement for the recipient `urn` in the first path is just an extra safety measure to avoid migrating collateral to an undesired `urn`. However for the second path is indeed mandatory as migrating debt can convert the recipient `urn` to another type of risk exposure. | |
| Note: The caller authed requirement for the recipient `urn` in the first path is just an extra safety measure to avoid migrating collateral to an undesired `urn`. However for the second path it is indeed mandatory as migrating debt increases the debt of the recipient `urn`. |
telome
reviewed
Mar 26, 2025
| @@ -5,14 +5,13 @@ pragma solidity ^0.8.21; | |||
| import "dss-test/DssTest.sol"; | |||
| import { LockstakeEngine } from "src/LockstakeEngine.sol"; | |||
| import { LockstakeClipper } from "src/LockstakeClipper.sol"; | |||
| import { LockstakeMkr } from "src/LockstakeMkr.sol"; | |||
| import { LockstakeSky } from "src/LockstakeSky.sol"; | |||
There was a problem hiding this comment.
Further down, in invariant_call_summary, we can remove the printouts for lockSky/freeSky.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.