Disable writing parsetab files to disk. #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
(Full disclosure, I haven't tested this at all because I'm not sure how to.) |
jfly
force-pushed
the
issue-206-ply-race
branch
from
d4942ad
to
4f63fc2
Compare
|
Bump! Any feedback on this PR? |
|
Bump! |
|
Bump! Can anyone take a look? |
This fixes mailgun#206. Before this change, when multiple Python processes are simultaneously doing a `from flanker.addresslib import address`, it's possible for some of them to crash in `ply` code. See dabeaz/ply#184, where I attempted to work around this issue by changing ply. You can see in this comment: dabeaz/ply#184 (comment) that the author of ply suggests two workarounds for this issue: 1. Remove `ply` as a dependency in setup.py and copy the source code of `ply` into `flanker`. 2. Disable writing parsetab files to disk when invoking `yacc`. 2) seemed like the simpler solution to me, so that's what I've done here.
jfly
force-pushed
the
issue-206-ply-race
branch
from
4f63fc2
to
0dfed2e
Compare
|
Bump! Anyone got some time to take a look at this? |
|
I'm running into this crash as well. Thanks for the work @jfly . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #206.
Before this change, when multiple Python processes are simultaneously
doing a
from flanker.addresslib import address, it's possible for someof them to crash in
plycode.See dabeaz/ply#184, where
I attempted to work around this issue by changing ply. You can see in this comment: dabeaz/ply#184 (comment) that the author of ply suggests two workarounds for this issue:
plyas a dependency in setup.py and copy the source code ofplyintoflanker.yacc.here.