Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the existing validation flow for sieve filter #6205

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

PhoenixPeca
Copy link
Contributor

@PhoenixPeca PhoenixPeca commented Dec 11, 2024

Contribution Guidelines

What does this PR include?

This PR improves the existing validation method flow for sieve filter validations.

Short Description

The current validation behavior sends AJAX request form data in $_GET request query. This is problematic and unreliable when validating particularly complex and superrrr loooooooooooooong sieve rules, especially in environments that use reverse proxies--Been having this problem and this PR solves it. :)

Affected Containers

  • NGINX--i think

Did you run tests?

Yes.
image

What did you tested?

The sieve validation feature. :)
https://mail.cow.com/mailbox -> Filters Tab -> Global Prefilter/Postfilter

What were the final results? (Awaited, got)

Should show a toast notif that the sieve filter is valid or is erroneous. ;)

Sorry, something went wrong.

tested from my end.
This AJAX request sends form data in $_GET request query. This is problematic and unreliable when validating superrrr loooooong conditions, especially in environments that use reverse-proxy.

Been having this problem and this PR solves it. :)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant