Fix #2752 - Allow domain recipients for address rewrite #6155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PseudoResonance
force-pushed
the
fix2752
branch
from
51fea7f to
40f6d69
Compare
PseudoResonance
changed the title
DerLinkman
force-pushed
the
staging
branch
2 times, most recently
from
aaee040 to
4d688c5
Compare
(cherry picked from commit 40f6d69)
PseudoResonance
force-pushed
the
fix2752
branch
from
40f6d69 to
b6a9550
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution Guidelines
What does this PR include?
Short Description
Fix for #2752 to allow address rewriting to entire domains, instead of being limited to a single email.
I simply copied the old address validation code and replaced the new address validation so that they both share the same code.
Affected Containers
Did you run tests?
What did you tested?
I inputted a number of different valid/invalid domain and email combinations to ensure the validation works as intended.
What were the final results? (Awaited, got)
Works as described in #2752 and either exact emails or whole domains can be added as a new address.