Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken dependencies for dovecot image #5870

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from
Open

Fix broken dependencies for dovecot image #5870

wants to merge 2 commits into from

Conversation

icedream
Copy link

@icedream icedream commented May 5, 2024

  • Fix python 3.11 vs 3.12 breakage because of edge repository usage
  • Fix gosu armhf dependency (@MAGICCC do we even want to support this properly?)

@milkmaker
Copy link
Collaborator

Thanks for contributing!

I noticed that you didn't select staging as your base branch. Please change the base branch to staging.
See the attached picture on how to change the base branch to staging:

check_prs_if_on_staging.png

@icedream
Only use edge-community repository explicitly for perl-lockfile-simple.
a60cf2b 
Adding the --repository parameter applies it to all packages and breaks some dependencies now.
@icedream
Fix gosu dependency for armhf.
ac45836
@icedream icedream changed the base branch from master to staging May 5, 2024 14:53
@icedream
Copy link
Author

icedream commented May 5, 2024 •
edited

Tested with

docker build --platform=armhf --rm --no-cache data/Dockerfiles/dovecot
docker build --platform=aarch64 --rm --no-cache data/Dockerfiles/dovecot
docker build --platform=amd64 --rm --no-cache data/Dockerfiles/dovecot

@MAGICCC MAGICCC requested a review from DerLinkman May 5, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DerLinkman DerLinkman Awaiting requested review from DerLinkman

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@icedream @milkmaker