ei: Fix flipped scroll axes #406
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadeokondrak
force-pushed
the
ei-scroll-axes
branch
from
afc52c5 to
f305af1
Compare
|
I think the better solution is to remove the uses of the magic numbers 0 and 1 and replace them with the VERTICAL_SCROLL and HORIZONTAL_SCROLL constants. Outgoing EI messages are broken in the same way as far as I can tell. |
tadeokondrak
force-pushed
the
ei-scroll-axes
branch
2 times, most recently
from
004641d to
490eb5b
Compare
|
I've added some additional changes to make handling of axes more robust. Please test the current version. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows for emulating ordinary vertical scrolling with libei. I think horizontal scrolling might be broken due to this but I haven't looked into that yet.