Skip to content

Commit

Permalink
chore
Browse files Browse the repository at this point in the history
  • Loading branch information
magne4000 committed Feb 26, 2025
1 parent e5acf3f commit a1bea10
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 21 deletions.
2 changes: 1 addition & 1 deletion examples/demo/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
"react": "^18.3.1",
"react-dom": "^18.3.1",
"typescript": "^5.7.3",
"vike": "0.4.223-commit-59f3966",
"vike": "0.4.223-commit-535bde1",
"vike-react": "^0.5.13",
"vike-vercel": "workspace:^",
"vite": "^6.1.1",
Expand Down
2 changes: 1 addition & 1 deletion examples/demo/pages/isr/+config.ts
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import type { Config } from "vike/types";

export default {
// TODO should automatically be set by `vike-vercel`
// FIXME: Setting ISR should disable prerendering
prerender: false,
isr: { expiration: 5 },
} satisfies Config;
2 changes: 1 addition & 1 deletion packages/vike/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,6 @@
},
"dependencies": {
"@brillout/libassert": "^0.5.8",
"vike": "0.4.223-commit-59f3966"
"vike": "0.4.223-commit-535bde1"
}
}
16 changes: 8 additions & 8 deletions packages/vike/src/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,14 @@ export default {
isr: {
env: { server: true, config: true },
eager: true,
// effect({ configValue }) {
// // an actual ISR value exists for a Page
// if (configValue) {
// return {
// prerender: false,
// };
// }
// },
effect({ configValue, configDefinedAt }) {
// an actual ISR value exists for a Page
if (configValue) {
return {
prerender: false,
};
}
},
},
edge: {
env: { server: true, config: true },
Expand Down
20 changes: 10 additions & 10 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit a1bea10

Please sign in to comment.