Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Stub Compilation Errors and Update Documentation for Running Binaries #53

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

sudheesh001
Copy link

This PR contains two commits. The first commit focuses on fixing a compilation error because of missing ueIdLst
The second commit focuses on updating the documentation to build the Controller Stub binaries for running tests.

Co-authored-by: Sudheesh Singanamalla <[email protected]>
Co-authored-by: Nick Durand <[email protected]>

Signed-off-by: Sudheesh Singanamalla <[email protected]>
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 17, 2021
@ulaskozat
Copy link
Contributor

@rsarwad and @pruthvihebbani could you review this PR? Thanks.

@@ -1467,6 +1467,7 @@ typedef struct _PartialReset
{
U32 numOfConn;
UeS1apIdPair *ueS1apIdPairList;
U32 *ueIdLst;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sudheesh001 Is this parameter used? because fw_api_init.c; I could see this parameter is not being used.

1593 else if(msgReq->t.resetReq.rstType == NB_PARTIAL_RESET)
1594 {
1595 msgReq->t.resetReq.u.partialRst.numOfConn = data->r.partialRst.numOfConn;
1596 FW_ALLOC_MEM(
1597 fwCb, &msgReq->t.resetReq.u.partialRst.ueS1apIdPairList,
1598 sizeof(NbUeS1apIdPair) * msgReq->t.resetReq.u.partialRst.numOfConn);
1599
1600 cmMemcpy(
1601 msgReq->t.resetReq.u.partialRst.ueS1apIdPairList,
1602 data->r.partialRst.ueS1apIdPairList,
1603 sizeof(NbUeS1apIdPair) * msgReq->t.resetReq.u.partialRst.numOfConn);
1604 }
1605 else
1606 {
1607 FW_LOG_ERROR(fwCb, "Invalid reset Type");
1608 FW_LOG_EXITFN(fwCb, RFAILED);
TestCntlrApp/src/tfwApp/fw_api_int.c

Once Reset message is received at test framwork application, later posts the message to eNB application; Even while it get posted. we don't see this parameter. Below is the structure that gets populated while posted to eNB application
231 typedef struct _mnPartialReset
232 {
233 U32 numOfConn;
234 NbUeS1apIdPair *ueS1apIdPairList;
235 }NbPartialReset;
236

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rsarwad Thank you for the review. We do see this in the TestCntlrStub which fails to build at these lines where ueIdLst is used.

((ResetReq*)msgptr)->r.partialRst.numOfConn = numOfUes;
((ResetReq*)msgptr)->r.partialRst.ueIdLst = malloc(numOfUes);
memcpy(((ResetReq*)msgptr)->r.partialRst.ueIdLst, ueLst, numOfUes);

Given what you mentioned, it looks like the Stub might be out of date and should rather use UeS1apIdPair by doing something like:

((ResetReq*)msgptr)->r.partialRst. ueS1apIdPairList = malloc(sizeof(UeS1apIdPair) * numOfUes);
memcpy(((ResetReq*)msgptr)->r.partialRst. ueS1apIdPairList, modifiedUeLst, numOfUes);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes right

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants