-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use tracing crate #254
use tracing crate #254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool :) Thanks for working on this!
Apart from the open question about tracing_subscriber and having to test this a bit more this looks good to go. Tracing should be compatible with log, given the feature is enabled so I think we can land this in a point release.
Oh and according to CI there are a few |
oh nice catch! I forgot to run clippy with |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #254 +/- ##
==========================================
- Coverage 37.69% 37.14% -0.56%
==========================================
Files 18 18
Lines 3170 3166 -4
==========================================
- Hits 1195 1176 -19
- Misses 1975 1990 +15 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a rebase, I got #255 in first.
MR has been rebased! |
thanks again :) |
This commit introduces the
tracing
, replacing the existing log crate. This commit addresses this issue raised here last week.