Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use tracing crate #254

Merged
merged 1 commit into from
Sep 3, 2024
Merged

use tracing crate #254

merged 1 commit into from
Sep 3, 2024

Conversation

spl0i7
Copy link
Contributor

@spl0i7 spl0i7 commented Aug 18, 2024

This commit introduces the tracing, replacing the existing log crate. This commit addresses this issue raised here last week.

Copy link
Collaborator

@felinira felinira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool :) Thanks for working on this!

Apart from the open question about tracing_subscriber and having to test this a bit more this looks good to go. Tracing should be compatible with log, given the feature is enabled so I think we can land this in a point release.

src/core/test.rs Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@felinira
Copy link
Collaborator

Oh and according to CI there are a few log references left in tests. https://github.com/magic-wormhole/magic-wormhole.rs/actions/runs/10439844805/job/28909006119?pr=254#step:11:148

@spl0i7
Copy link
Contributor Author

spl0i7 commented Aug 18, 2024

Oh and according to CI there are a few log references left in tests. https://github.com/magic-wormhole/magic-wormhole.rs/actions/runs/10439844805/job/28909006119?pr=254#step:11:148

oh nice catch! I forgot to run clippy with --all-targets

Copy link

codecov bot commented Aug 18, 2024

Codecov Report

Attention: Patch coverage is 29.41176% with 84 lines in your changes missing coverage. Please review.

Project coverage is 37.14%. Comparing base (6d8a9c8) to head (0512170).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cli/src/main.rs 0.00% 22 Missing ⚠️
src/forwarding.rs 0.00% 18 Missing ⚠️
src/transit.rs 43.47% 13 Missing ⚠️
src/transfer/cancel.rs 7.69% 12 Missing ⚠️
src/transfer/v1.rs 60.86% 9 Missing ⚠️
src/core/rendezvous.rs 50.00% 3 Missing ⚠️
src/transfer/offer.rs 33.33% 2 Missing ⚠️
src/transit/transport.rs 66.66% 2 Missing ⚠️
src/core.rs 66.66% 1 Missing ⚠️
src/core/key.rs 0.00% 1 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #254      +/-   ##
==========================================
- Coverage   37.69%   37.14%   -0.56%     
==========================================
  Files          18       18              
  Lines        3170     3166       -4     
==========================================
- Hits         1195     1176      -19     
- Misses       1975     1990      +15     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@felinira felinira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a rebase, I got #255 in first.

Cargo.toml Outdated Show resolved Hide resolved
@spl0i7
Copy link
Contributor Author

spl0i7 commented Aug 26, 2024

MR has been rebased!

@felinira
Copy link
Collaborator

felinira commented Sep 3, 2024

thanks again :)

@felinira felinira merged commit 22b261b into magic-wormhole:main Sep 3, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants