Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(oauth): sort parameters in a standard way as per the specs #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

real34
Copy link
Member

@real34 real34 commented Sep 15, 2020

This PR is similar to OpenMage/magento-lts#721
Please read the full description there.

TL;DR

Parameters must be "sorted by name, using lexicographical byte value ordering" (from Oauth specs) which is incorrect if using strnatcmp.

Magento is not able to validate signatures for requests with parameters such as /rest/V1/foo?keys[0]=test1&keys[1]=test2&keys[2]=test3&keys[3]=test4&keys[4]=test5&keys[5]=test6&keys[6]=test7&keys[7]=test8&keys[8]=test9&keys[9]=test10&keys[10]=test11 as it will consider that keys[10] goes after keys[9] whereas it should be ordered between keys[1] and keys[2].

the signature is now calculated a bit differently to match other
implementations.

BREAKING CHANGE: existing OAuth applications may encounter some issues
leading to `invalid_signature` 401 errors from Magento due to the
removal of natural sorting for parameters when generating the signature
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant