PWA-4468: use the same version of react-tabs
everywhere
#4469
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When running yarn install, Yarn throws an invariant violation and fails to install.
I traced this down to packages/pagebuilder/package.json which defines:
This breaks Yarn workspaces because it can't resolve to a single version.
Additional context: this issue was uncovered while testing with Node Corepack enabled. This is a recent-ish mode in Node which uses a Node-bundled version of Yarn instead of globally installed Yarn. Our team ran into multiple issues converting to that, and chose to continue using globally installed Yarn. But it did help highlight this dev/peer dependency difference with the
react-tabs
dependency. It seemed like an easy fix to make all the monorepo packages ask for3.1.0
.Related Issue
Closes #4468
Acceptance
Verification Stakeholders
Specification
Verification Steps
Test scenario(s) for direct fix/feature
Test scenario(s) for any existing impacted features/areas
Test scenario(s) for any Magento Backend Supported Configurations
Is Browser/Device testing needed?
Any ad-hoc/edge case scenarios that need to be considered?
Screenshots / Screen Captures (if appropriate)
Breaking Changes (if any)
Checklist