[FIC] Implement Fandaniel, Telophoroi Ascian #13631
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theelk801
requested changes
May 15, 2025
| public boolean apply(Game game, Ability source) { | ||
| int damage = 2 * amount.calculate(game, source, this); | ||
| if (damage <= 0) { | ||
| return true; |
There was a problem hiding this comment.
this needs to give opponents the option of sacrificing even if they wouldn't take damage
| if (!cost.canPay(source, source, opponentId, game) | ||
| || !opponent.chooseUse(Outcome.Detriment, "Sacrifice a nontoken creature to avoid " + damage + " damage?", source, game) | ||
| || !cost.pay(source, game, source, opponentId, false)) { | ||
| opponent.loseLife(damage, game, source, false); |
There was a problem hiding this comment.
You need to have each player choose their sacrifice, then they do the sacrifice after choosing, then do the damage. Check out how SacrificeAllEffect is written
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Fandaniel, Telophoroi Ascian