Update render mode selection #13579
Open
Update render mode selection #13579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* changes render mode selection to a drop-down * modes include MTGO, Image, Forced M15, Forced Retro * debug card test panel updated with additional modes as well
|
Anything in particular you want a reviewer to look at? I definitely endorse the direction |
|
Wording of setting names and reminder text mostly. Also, I figured @JayDi85 would want to look at it first before merging. |
|
For the mouseover descriptions, maybe make it more clear that forced m15/retro are a variation on mtgo style? Can you include a screenshot of the new debug panel for reference? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PreferencesDialog.getRenderMode() uses the enum ordinal to reduce the amount of refactoring