Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MKM] Implement Cryptic Coat and Cloak ability #12164

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

Susucre
Copy link
Contributor

@Susucre Susucre commented Apr 21, 2024

Implement Cryptic Coat (and it's cloak effect) adding a boolean to ManifestEffect/doManifestCards.

It is functional and works in my alpha server.
It does share the current bugs for Manifest and more generally Face Down, and does not show the Ward {2} properly like Disguise. Other than that it works fine enough.

In my opinion it could be merged like this in the beta. I don't really care if not, just wanted to share the work done as a courtesy. I don't plan to add/tweak it, so feel free to do it.

Note: maintainers edits are voluntarily disabled, since I'm using the branch on my repo for the alpha build. Cherry-pick the commit in your own branch/PR if you desire to use and tweak.

Copy link

Cryptic Coat - (Gatherer) (Scryfall) (EDHREC)

{2}{U}
Artifact — Equipment
When Cryptic Coat enters the battlefield, cloak the top card of your library, then attach Cryptic Coat to it. (To cloak a card, put it onto the battlefield face down as a 2/2 creature with ward {2}. Turn it face up any time for its mana cost if it's a creature card.)
Equipped creature gets +1/+0 and can't be blocked.
{1}{U}: Return Cryptic Coat to its owner's hand.

@Susucre
Copy link
Contributor Author

Susucre commented Apr 21, 2024

image

Turning the right one face up:
image

@Susucre Susucre changed the title [MKM] Implement Cryptic Cloak [MKM] Implement Cryptic Coat Apr 21, 2024
@Susucre Susucre force-pushed the cloak branch 2 times, most recently from 5d1cb04 to 3bdf243 Compare May 5, 2024 19:10
@Susucre
Copy link
Contributor Author

Susucre commented Jun 6, 2024

@JayDi85 unless your Cloak implementation is coming in short term, how about the not ideal version using Manifest as a base like here? (for Cloak and the other few cloak cards from MKM)

This one was made without a lot of thought, just to be able to have play it in my cube.
I'll clean it / make it better, but I don't plan on doing the whole face down rework you want to do.
I made a bunch of related issues on face down when I was working on it (because all the issues are Manifest/Disguise ones already).

@JayDi85 JayDi85 changed the title [MKM] Implement Cryptic Coat [MKM] Implement Cryptic Coat and Cloak ability Jun 6, 2024
Copy link
Member

@JayDi85 JayDi85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's same, can be merge

@Susucre Susucre merged commit ab280ad into magefree:master Jun 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants