Improve special character handling in package revisions #9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the yarn plugin generates invalid nix paths when package revisions with paths (i.e.
workspace:
andpatch:
protocols) contain nix store illegal characters. This is really annoying when patching scoped packages, as the@
symbol is also forbidden in store paths.Generated code without this patch:
Generated code with this patch:
Note 1: Only store-illegal paths are changed. All valid paths are still generated the normal way. I have verified that the generated manifest in
test/
is exactly the same with this patch.Note 2: I tried to follow the formatting used elsewhere in this file, but I'm not sure about, for example, the preferred line lengths.
Note 3: I think there is nothing inherently non-portable about the code, but I don't have a darwin machine to test it on, so verifying that everything works would be much appreciated. :)