Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

litehtml: update to 0.9-20240402; litebrowser: update to 0.0.0-20240331 #23345

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

barracuda156
Copy link
Contributor

Description

Update these

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 14.4.1
Xcode 15.3

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL in commit message?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?
  • checked that the Portfile's most important variants haven't been broken?

@macportsbot
Copy link

Notifying maintainers:
@ryandesign for port litehtml, litebrowser.

@barracuda156
Copy link
Contributor Author

Can’t say it’s of tremendous utility, but it works:
image

Copy link
Contributor

@ryandesign ryandesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I had worked on updating the port to 0.8 back when it was released but encountered three problems that the developer never acknowledged: litehtml/litehtml#264, litehtml/litehtml#270, litehtml/litehtml#271. It doesn't look like you included fixes for any of these in your PR so I'll want to investigate whether such fixes are still needed or whether the developer may have fixed the problems already without noting it in the issues.

Comment on lines +7 to +8
github.setup litehtml litehtml b5ab35fa12ca27461cc1c0b814ac217410ac8054
version 0.9-20240402
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit is the latest one, which is several months past the release of 0.9. What problems did you encounter with the 0.9 release that prompted you to update further?

Comment on lines -1 to -2
Fix include path in installed container file to find litehtml.h where it
will be installed.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You removed the comment that explains what the patch is for. I think I'd like to keep it.

Comment on lines -13 to +15
pkg_check_modules(LB_LIBS REQUIRED fontconfig gdkmm-3.0 gtkmm-3.0 libcurl cairo pango pangocairo)
pkg_check_modules(LB_LIBS REQUIRED gdkmm-3.0 gtkmm-3.0 libcurl cairo pango pangocairo)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it no longer checks for fontconfig then I guess it should be removed from depends_lib too.

@ryandesign
Copy link
Contributor

Can’t say it’s of tremendous utility, but it works:

It's not intended to be of tremendous utility as a standalone web browser. litehtml is an HTML-rendering library intended to be used by other software when needing to render small bits of HTML in their UI. Tooltips were given as an example use case. The litehtml library is in MacPorts so that ports can depend on it when needed for such purposes and also because I am interested in HTML-rendering libraries for use in one of my own projects. claws-mail, for example, uses litehtml, although it uses a bundled copy, not the one from MacPorts; litehtml is still too early in development to have a stable API. The litebrowser port is present for anyone who wants to verify the functionality of the litehtml library.

@barracuda156
Copy link
Contributor Author

@ryandesign Sure, thank you. We should indeed check if extra fix-ups are needed, given that there were known issues (I was unaware of those).

@pmetzger
Copy link
Member

Conflicts. Plus, how do we get this moving?

@barracuda156
Copy link
Contributor Author

Well, I was waiting for @ryandesign – no point rebasing until he approves. (Conflict arose due to a gumbo-parser-caused revbump.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintainer: open Affects an openmaintainer port type: update
4 participants