Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mpich: app a patch from libfabric upstream for a case of missing AI_NUMERICSERV #16282

Merged
merged 1 commit into from
Nov 15, 2022

Conversation

barracuda156
Copy link
Contributor

Description

(Small and hopefully uncontroversial PR, submitting now otherwise may get forgotten.)

This fix – borrowed originally from graphviz code – is already merged into upstream: ofiwg/libfabric@522a3db
However since mpich uses an old version of libfabric, it makes sense to have a patch until mpich moves to a newer version.
The problem of missing AI_NUMERICSERV has been resurfacing with several ports and different OS. See:
#14932 (MoarVM)
https://trac.macports.org/ticket/41916 (graphviz)

Type(s)
  • bugfix
  • enhancement
  • security fix
Tested on

macOS 10.6 PPC
Xcode 3.2

Verification

Have you

  • followed our Commit Message Guidelines?
  • squashed and minimized your commits?
  • checked that there aren't other open pull requests for the same change?
  • referenced existing tickets on Trac with full URL?
  • checked your Portfile with port lint --nitpick?
  • tried existing tests with sudo port test?
  • tried a full install with sudo port -vst install?
  • tested basic functionality of all binary files?

@macportsbot
Copy link

Notifying maintainers:
@mascguy for port mpich.
@eborisch for port mpich.

@mascguy
Copy link
Member

mascguy commented Oct 4, 2022

Since CI needs to build 13 subports - and each takes quite a while - CI will always timeout. So go ahead and add another line to the commit message to disable it: [skip ci].

Ultimately we'll need to validate this locally, when time allows.

@barracuda156 barracuda156 marked this pull request as ready for review October 4, 2022 21:35
@barracuda156
Copy link
Contributor Author

Since CI needs to build 13 subports - and each takes quite a while - CI will always timeout. So go ahead and add another line to the commit message to disable it: [skip ci].

Ultimately we'll need to validate this locally, when time allows.

@mascguy Thank you! Done.

@mascguy mascguy marked this pull request as draft October 4, 2022 21:37
@barracuda156
Copy link
Contributor Author

@mascguy By the way, maybe we could add this to legacysupport somehow? We will keep getting this kind of error with other ports (maybe few, this I cannot say, but I encountered it at least with three).

@barracuda156
Copy link
Contributor Author

@eborisch Maybe you could merge this, since @mascguy is busy presently?

@barracuda156 barracuda156 changed the title mpich: app a patch for case of missing AI_NUMERICSERV mpich: app a patch from libfabric upstream for a case of missing AI_NUMERICSERV Nov 15, 2022
@barracuda156 barracuda156 marked this pull request as ready for review November 15, 2022 05:16
@kencu kencu merged commit 205cb3c into macports:master Nov 15, 2022
@barracuda156 barracuda156 deleted the mpich branch November 15, 2022 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants