Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increasing amount of JS snippets #80

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Increasing amount of JS snippets #80

wants to merge 3 commits into from

Conversation

benFromMabl
Copy link
Contributor

Added collection of Javascript snippets covering a wide range of topics frequently asked about.

DancingNerd
DancingNerd requested changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@DancingNerd DancingNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a bunch of comments. Take a look and let me know! Also, for all of them it would be good to run them through the prettier formatter

mabl snippets/addDay.js Outdated Show resolved Hide resolved
mabl snippets/browserPageRefresh.js Outdated Show resolved Hide resolved
mabl snippets/browserPageRefresh.js Show resolved Hide resolved
mabl snippets/changeInputValue.js Outdated Show resolved Hide resolved
mabl snippets/changeInputValue.js Show resolved Hide resolved
mabl snippets/setCookie.js Outdated Show resolved Hide resolved
mabl snippets/setCookie.js Outdated Show resolved Hide resolved
mabl snippets/setCookie.js Outdated Show resolved Hide resolved
mabl snippets/stringCombinedExample.js Outdated Show resolved Hide resolved
mabl snippets/warningExample.js Outdated Show resolved Hide resolved
@benFromMabl
Prettier'd all the snippets.
14b4356 
Returned GetDateComponents.js to its original name to not break links.
Made adjustments based on code review feedback.
@benFromMabl
More adjustments based on code review
49066a1
DancingNerd
DancingNerd approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@DancingNerd DancingNerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull in the recent changes first and then this should be good to go. Try to match the existing format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DancingNerd DancingNerd DancingNerd approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
2 participants
@benFromMabl @DancingNerd