A cleaner autotools implementation of the gzip reading code #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed some tabs, added some spaces here and there.
- Add a ./configure option --with-boost-iostreams (enabled by default) - Add a ./configure option --with-boost-include-path so the user can tell configure where to find the libraries if they are not in the default locations - Add an Automake option WITH_BOOST_IOSTREAMS that is true if the lib can be found (well, if the gzip.hpp file can be found) and use this to add the LDADD flags for the binaries that need it. This option is also used in the C++ code to switch between compiling with or without Boost::iostreams. - Print the version of the Boost library if Boost is used - In gendata.cpp keep the option open to read files when the library is not present. Unfortunately this does leave the code more ugly with a bunch of #ifdefs...
|
I have created a feature request to track this idea of reading gzipped files: GenABEL-Project#12 |
maarten-k
added a commit
that referenced
this pull request
Nov 15, 2015
A cleaner autotools implementation of the gzip reading code
|
Hi Maarten, Would it be possible for you to create a new branch and commit the changes in your fork (w.r.t. the main repo at https://github.com/GenABEL-Project/ProbABEL) into that branch? That would make it easier for me to integrate your work with the main repository. See for example this StackOverflow question on how to do that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Maarten,
I used some code from the
ProbABEL-pvalsbranch to add a few ./configure options that check for the required Boost library. This PR also keeps the option open of not using the Boost lib (and then live without the ability to read gzipped data).