Split site-selection endpoints to their own module #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemeli
force-pushed
the
siteselect
branch
3 times, most recently
from
679e681 to
66bff81
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on #60, and should only be merged after that. This is a bit of a work-in-progress, so this branch may get rebased on occasionally.
The REST API changes a little here, as what used to be
GET people/:id/ballotis nowGET siteselect/:id/ballot, and it no longer requires that a token has been purchased (this is the endpoint that returns a form-filled PDF ballot). Site-selection admins may now also fetch a member's ballot.In order for the (newly added) tests to pass consistently, the
reset_test_users()postgres function now also sets the[email protected]user's key.There are a couple of integration points for site-selection actions that are not included in this module (token generation, transactional email contents,
/config/siteselection). Not sure whether those should be pulled in here as well, and if so, how exactly.