xmrwallet build based on ndk29 and boost 1.81 #1013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niyid
changed the title
Owner
|
970 commits? please rebase on master. i think i saw hardcoded paths to your build envirnoment as well |
Author
Thanks for getting back and congratulations on all your good work. You already did all the heavy lifting. Kudos. Please do your review so I can make any required/suggested changes. |
Owner
|
thanks & thank you! |
Author
|
Are you asking for higher Boost version? 1.81 -> 1.89? I think it is as
easy as updating the version number in the script. Let me know exactly what
you are asking for and we can take it from there.
…On Thu, 18 Dec 2025, 16:09 m2049r, ***@***.***> wrote:
*m2049r* left a comment (m2049r/xmrwallet#1013)
<#1013 (comment)>
thanks & thank you!
i assume boost 1.81 is necessary to compile with ndk29? if not, we should
stick as close as possible to the gitian build versions of monero (check
out contrib/gitian in monero repo)
no other dependencies need to be updated?
—
Reply to this email directly, view it on GitHub
<#1013 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE2MWR7EZJ4BXNYPSFKK2OT4CK7STAVCNFSM6AAAAACKXL7DSKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTMNZQG43TGNRQGQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
PROBLEM: Java class has overloaded methods getSeed() and getSeed(String) but only one JNI function was implemented, causing parameter mismatch. When getSeed() (no params) was called, JNI received invalid data, leading to: 'JNI ERROR (app bug): attempt to use stale Global 0x209a (should be 0x2096)' ROOT CAUSE: - Missing JNI implementation for overloaded getSeed() method - JNI name mangling not handled for overloaded native methods - No validation of JNI references before use SOLUTION: Implement both JNI functions with proper name mangling: - Java_com_m2049r_xmrwallet_model_Wallet_getSeed__ (no params) - Java_com_m2049r_xmrwallet_model_Wallet_getSeed__Ljava_lang_String_2 (with param) Add shared internal implementation with safe string extraction, comprehensive error handling, and thread safety. CHANGES: - Added getSeedInternal() shared implementation - Added extractJString() safe string extraction helper - Added both JNI functions for overloaded methods - Updated JNI native method registration - Added defensive exception clearing and error handling - Maintained thread safety with mutex protection IMPACT: Eliminates crashes during wallet seed retrieval, improves app stability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This build was entirely fashioned by Claude Sonnet 4.5 and I merely guided it. I want that piece of information noted.