Support transcriptions and update to latest API changes - #56
Open
jblwilliams wants to merge 2 commits into
Open
Support transcriptions and update to latest API changes #56jblwilliams wants to merge 2 commits into
jblwilliams wants to merge 2 commits into
Conversation
Remove model from connect API and rely on configuration changes or initial client_secrets API call to configure Add conversationItemAdded server event and use previousItemId to place entries in correct position
|
I appreciate you working in this 🙏🏽 This was a blocker for me |
|
It's not even connecting on my end . |
Author
|
@fcrmlk can you elaborate on the error you're seeing and your setup? Are you not connecting with current main or my branch? |
|
main branch of your code. |
Author
|
@fcrmlk there are various things that could be breaking with the connection. I would love to help you debug but without you sharing more detailed information about how you're configuring your connection and sharing the logs you're seeing from the failed connection, then I won't be able to help. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all, thank you for making this library! I was testing this with Realtime Transcriptions and came across several issues that I've attempted to patch.
I've made several changes as I was testing but some are breaking changes. I wanted to open this PR to invite further discussion on what the best way to evolve the API would be.
Major Changes
I needed to remove
Model?from theconversation.connectcall because it was overriding the initial session object I created server side to create an ephemeral key. I'm doingtranscriptionnotrealtimeand the override was forcing an invalid change. I could see an argument either way for only supporting session updates after the connection is established. The OpenAI API docs seem to encourage this pattern via example here since they're configuring the session to get theclient_secret/ephemeral_key