OrphanedObjects: detect object vs. multipart vs. unexpected file #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This expands OrphanedObjectsCheck::check() to understand different types of file, based on what their filenames look like. The rules here are: - If the filename is an integer number (i.e. matches "^[0-9]+$") then it's assumed to be a versioned object, and the concatenation of its parent directories provides the object UUID. - If the filename looks like most of a UUID, but with a dash and an integer stuck on the end, it's part of a multipart upload. - If the filename doesn't match one of the above, it shouldn't be there at all. The current implementation doesn't explicitly check that parent directories are sane given the file type, but if (for example) an integer-looking-filename (assumed versioned object) appears at the wrong level in the directory hierarchy, it will still be reported as an orphaned object because the UUID obtained from path concatenation won't match anything in the database. Signed-off-by: Tim Serong <[email protected]>
This commit also adds an UnexpectedFileFix class. Signed-off-by: Tim Serong <[email protected]>
tserong
force-pushed
the
wip-enhance-orphaned-objects
branch
from
55159fd to
b6715e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands OrphanedObjectsCheck::check() to understand different types of file, based on what their filenames look like. The rules here are:
The current implementation doesn't explicitly check that parent directories are sane given the file type, but if (for example) an integer-looking-filename (assumed versioned object) appears at the wrong level in the directory hierarchy, it will still be reported as an orphaned object because the UUID obtained from path concatenation won't match anything in the database.