Add upfront database integrity check #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tim Serong <[email protected]>
If the SQLite database is itself corrupt, there's little point checking the files on the disk, because we have no metadata to check them against. So this is a special check that happens right at the start before all other checks. If the file is _so_ trashed it doesn't even look like an SQLite database then `PRAGMA integrity_check` will return immediately with an error and you'll see something like `sqlite3_exec error: file is not a database (26)` or `sqlite3_exec error: database disk image is malformed (11)`. If the file isn't too badly damaged (in my test I chopped 1KB off the end), the integrity check will actually run, and you'll see potentially several lines of output, e.g.: ``` *** in database main *** Fragmentation of 206 bytes reported as 0 on page 28 row 1 missing from index versioned_object_objid_vid_unique row 2 missing from index versioned_object_objid_vid_unique row 3 missing from index versioned_object_objid_vid_unique ``` Signed-off-by: Tim Serong <[email protected]>
Signed-off-by: Tim Serong <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the SQLite database is itself corrupt, there's little point checking
the files on the disk, because we have no metadata to check them against.
So this is a special check that happens right at the start before all
other checks.
If the file is so trashed it doesn't even look like an SQLite database
then
PRAGMA integrity_checkwill return immediately with an error andyou'll see something like
sqlite3_exec error: file is not a database (26)or
sqlite3_exec error: database disk image is malformed (11).If the file isn't too badly damaged (in my test I chopped 1KB off the end),
the integrity check will actually run, and you'll see potentially several
lines of output, e.g.:
This PR also updates the README and bumps the expected metadata schema to version 3