Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration with latest marshmallow (3.6.1) #24

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

tschaume
Copy link

An attempt to make progress on #16. pytest currently fails with

AttributeError: 'TestSchema' object has no attribute '_marshal'

patrick_Patricks-MBP____gitrepos_mp_MPContribs_mpcontribs-api_toasted-marshmallow

@tramora
Copy link

tramora commented Jun 2, 2022

Hi !
Thanks for the effort @tschaume. Unfortunatly the merge is blocked for 2 years now, is there any possible action to fix the automated test ?

@tschaume
Copy link
Author

tschaume commented Jun 2, 2022

@tramora I tried to make as much progress as I could back then and left this PR in case a maintainer would have the bandwidth to help me move this forward. I never ended up using toasted-marshmallow since I was under the impression that the speed-up wasn't as significant anymore with marshmallow3 🤷

@PavanTatikonda
Copy link

@tramora I tried to make as much progress as I could back then and left this PR in case a maintainer would have the bandwidth to help me move this forward. I never ended up using toasted-marshmallow since I was under the impression that the speed-up wasn't as significant anymore with marshmallow3 🤷

@tschaume do you have any docs/reference for this "the speed-up wasn't as significant anymore with marshmallow3 🤷" ?

@tschaume
Copy link
Author

@PavanTatikonda I unfortunately can't remember where I read it 😞 Maybe it was just an overall impression from reading the changelogs: https://marshmallow.readthedocs.io/en/stable/changelog.html#rc9-2019-07-31

@mLupine
Copy link

mLupine commented Oct 4, 2023

If anyone stumbles upon this issue hoping to get Toasted working with latest Marshmallow versions, I've created a fork of the project that works with all latest Marshmallow versions (3.13 and up), and does not require Marshmallow to be forked and modified. You can find it here: https://github.com/mLupine/DeepFriedMarshmallow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants