-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integration with latest marshmallow (3.6.1) #24
base: master
Are you sure you want to change the base?
Conversation
Hi ! |
@tramora I tried to make as much progress as I could back then and left this PR in case a maintainer would have the bandwidth to help me move this forward. I never ended up using |
@tschaume do you have any docs/reference for this "the speed-up wasn't as significant anymore with marshmallow3 🤷" ? |
@PavanTatikonda I unfortunately can't remember where I read it 😞 Maybe it was just an overall impression from reading the changelogs: https://marshmallow.readthedocs.io/en/stable/changelog.html#rc9-2019-07-31 |
If anyone stumbles upon this issue hoping to get Toasted working with latest Marshmallow versions, I've created a fork of the project that works with all latest Marshmallow versions (3.13 and up), and does not require Marshmallow to be forked and modified. You can find it here: https://github.com/mLupine/DeepFriedMarshmallow |
An attempt to make progress on #16.
pytest
currently fails with