Switch to ESM

[fisker]

@babel/code-frame@8 is now in ESM, reasonable to ship this module in ESM?

[lydell]

Hi! What are you doing that motivates this?

[fisker]

Sorry, forgot to write.. See updated PR description.

[fisker]

The main purpose is for Prettier

[lydell]

And what are you trying to achieve in Prettier? I’m not sure what you want to show with the screenshot.

[fisker]

ESbuild bundles CJS files like this

var require_js_tokens = __commonJS({
  // ...
});
var import_js_tokens = __toESM(require_js_tokens(), 1);
import_js_tokens.default(...);

And ESM files are like

// ...
var js_tokens_default = jsTokens;
js_tokens_default(...);

To me, the code is nicer.

I'm sending this since I thought you are open to ES modules, but it's fine if you don't want to accept.

[lydell]

I am open to ES modules, but I would rather switch to ESM-only than doubling the package size. So far, I haven’t really seen the benefit of making that breaking change, but since Node.js supports require-ing ESM (some) modules these days I think it might be time to finally make the switch.

[fisker]

Done

[fisker]

Should we add module.exports? https://nodejs.org/api/esm.html#commonjs-namespaces

[lydell]

Thanks, didn’t know about that feature. #61

[lydell]

Released in v10.0.0.

Thanks for the nudge and the help!