-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed display of broken option #572
base: master
Are you sure you want to change the base?
Conversation
I don't understand why but running it it activates |
I didn't understand what you meant. What's unchecked? Which screensaver? Where? |
I compiled that and forgot about after checking help and manpage, when I switched to Hyprland the screenlocker was activated on suspend without that this option was checked. Tested labwc and found the same, reinstalled |
Oh, you changed the code too; I didn't see that. With the removal of app.setConfigName(); However, I think it's better to fix that option, instead of removing it. Sadly, I don't remember what its problem was. |
Now I remember at least one of the problems: other LXQt config apps assume that the config file is If we want to remove this unused option, we should also change the code a little, because |
That's the reason. I remember I got an compile error about that line. |
There isn't :( A suggestion: Keeping the option but adding a warning that it isn't compatible with some LXQt configuration tools. |
Why keeping an non-working option... |
In an imaginary world, someone may want to use LXQt Session with that option and without LXQt config tools. |
With a probability hard al limit del measurable yes. |
Maybe there is more to clean up after.