fix(evdev): fix touch point reading failure #8029
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The values of dsc->min_x, dsc->max_x, dsc->min_y, and dsc->max_y are 0, causing an error in _evdev_calibrate that causes the screen touch to fail. So get the absinfo assignment for the x and y axes of the event device to dsc->min_x, dsc->max_x, dsc->min_y, dsc->max_y can fixes this error.
FASTSHIFT
approved these changes
Apr 8, 2025
FASTSHIFT
changed the title
liamHowatt
reviewed
Apr 9, 2025
|
We need some feedback on this pull request. Now we mark this as "Abandoned" because there was no activity here for 14 days. Remove the "Abandoned" label or comment else this will be closed in 7 days. |
|
Hey @TaoAaron, are you still free to get this across the finishing line ? 🏁 |
|
Let's continue in #8282 Seems like the micropython CI no longer works for v9.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1、When I was using lvgl release v9.0, I found that my touch screen had no touch feedback, but i can get touch coordinates from /dev/inputt/envent2. I added debugging information and found that the values of dsc->min_x, dsc->max_x, dsc->min_y, and dsc->max_y are all 0. This caused _evdev_calibrate to miscalculate, causing the reported screen coordinates to be wrong and the screen touch to fail.
2、So get the absinfo assignment for the x and y axes of the event device to dsc->min_x, dsc->max_x, dsc->min_y, dsc->max_y can fixes this error.
3、By the way, the latest release v9.2 does not have this bug.
Notes
lv_conf_template.hrun lv_conf_internal_gen.py and update Kconfig.scripts/code-format.py(astyle v3.4.12needs to installed by runningcd scripts; ./install_astyle.sh) and follow the Code Conventions.