Skip to content

Commit

Permalink
rp2/Makefile: Use cmake for "make submodules" task when needed.
Browse files Browse the repository at this point in the history
Because the submodule list can be updated by cmake files.

Signed-off-by: Andrew Leech <[email protected]>
  • Loading branch information
andrewleech authored and dpgeorge committed Jun 3, 2022
1 parent 21b3a39 commit 7d9cc69
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
10 changes: 9 additions & 1 deletion ports/rp2/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ CMAKE_ARGS += -DMICROPY_FROZEN_MANIFEST=${FROZEN_MANIFEST}
endif

all:
[ -d $(BUILD) ] || cmake -S . -B $(BUILD) -DPICO_BUILD_DOCS=0 ${CMAKE_ARGS}
[ -e $(BUILD)/CMakeCache.txt ] || cmake -S . -B $(BUILD) -DPICO_BUILD_DOCS=0 ${CMAKE_ARGS}
$(MAKE) $(MAKESILENT) -C $(BUILD)

clean:
Expand All @@ -28,4 +28,12 @@ clean:
GIT_SUBMODULES += lib/mbedtls lib/pico-sdk lib/tinyusb

submodules:
ifeq ($(BOARD),PICO)
# Run the standard submodules target with minimum required submodules above
$(MAKE) -f ../../py/mkrules.mk GIT_SUBMODULES="$(GIT_SUBMODULES)" submodules
else
# Run submodules task through cmake interface to pick up any board specific dependencies.
GIT_SUBMODULES=$$(cmake -B $(BUILD)/submodules -DECHO_SUBMODULES=1 -DGIT_SUBMODULES="$(GIT_SUBMODULES)" ${CMAKE_ARGS} -S . 2>&1 | \
grep 'GIT_SUBMODULES=' | cut -d= -f2); \
$(MAKE) -f ../../py/mkrules.mk GIT_SUBMODULES="$${GIT_SUBMODULES}" submodules
endif
7 changes: 7 additions & 0 deletions py/mkrules.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -178,3 +178,10 @@ if(MICROPY_FROZEN_MANIFEST)
VERBATIM
)
endif()

# Update submodules
if(ECHO_SUBMODULES)
# If cmake is run with GIT_SUBMODULES defined on command line, process the port / board
# settings then print the final GIT_SUBMODULES variable as a fatal error and exit.
message(FATAL_ERROR "GIT_SUBMODULES=${GIT_SUBMODULES}")
endif()

0 comments on commit 7d9cc69

Please sign in to comment.