This repository has been archived by the owner on Nov 7, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 69
[WIP] Implement Custom Command #79
Open
kevincox
wants to merge
4
commits into
lusakasa:master
Choose a base branch
from
kevincox:custom-command
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"name": "Custom Commands", | ||
"options": [ | ||
{ | ||
"type": "customcommands", | ||
"key": "customCommands", | ||
"default": [] | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
{ | ||
"name": "Custom Commands", | ||
"profiles": [ | ||
{ | ||
"name": "default", | ||
"options": { | ||
"customCommands": [] | ||
} | ||
} | ||
] | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
import { getAttributes } from 'lib/util' | ||
|
||
export default (options, config) => { | ||
console.error('CustomCommand/index.js called', options, config) | ||
const backgroundOptions = {} | ||
const clientOptions = {} | ||
const errors = {} | ||
return { backgroundOptions, clientOptions, errors } | ||
} |
45 changes: 45 additions & 0 deletions
45
.../options/Content/OptionsCard/OptionsList/OptionItem/OptionWidgets/CustomCommands/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,45 @@ | ||
import { Component, h } from 'preact' | ||
import TextArea from '../TextArea' | ||
|
||
const DEFAULT = { | ||
source: 'document.body.style.backgroundColor = "blue"' | ||
} | ||
|
||
class CustomCommand extends Component { | ||
render ({ command, onChange }) { | ||
return ( | ||
<li> | ||
<p>This is a command</p> | ||
<TextArea | ||
label='Source' | ||
value={command.source} | ||
onChange={s => onChange({ source: s, ...command })} | ||
/> | ||
</li> | ||
) | ||
} | ||
} | ||
|
||
export default class CustomCommands extends Component { | ||
render ({ key, value, onChange, ...rest }) { | ||
console.log('CustomCommands', key, value, rest) | ||
return ( | ||
<li> | ||
<ul> | ||
{value && | ||
value.map((cmd, i, cmds) => { | ||
let cmdChange = cmd => { | ||
let updated = cmds.slice() | ||
updated[i] = cmd | ||
onChange(updated) | ||
} | ||
return <CustomCommand command={cmd} onChange={cmdChange} /> | ||
})} | ||
</ul> | ||
<button onClick={e => onChange([...value, DEFAULT])}> | ||
New custom command | ||
</button> | ||
</li> | ||
) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, Widgets are meant to be standalone containers representing a single option. Although code reuse is nice, I think it's important to be able to change the TextArea Widget independently of the CustomCommand Widget.