This repository has been archived by the owner on Nov 7, 2022. It is now read-only.
NOT READY: New Firefox duplicate background tab fix + version check #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixed works for me! Running Firefox 96 on Ubuntu 20.04. |
|
Noticed that this broke the normal clicking. So I did a bit of snooping since this was bugging me 😌. Opened a PR on the personal repo: seanjennings960#2 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple fix for the duplicate background tabs problem happening since about Firefox 96, according to this Vimium commit.
This disables the extra
clickevent for Firefox >= 96.However, on Arch Linux (which has the latest Firefox), with Firefox 96, the user agent string is still showing as Firefox 91. So the version check is incorrect. I'm not certain if this happens on more peoples' machines than mine.The reason it did not work for me was becauseprivacy.resistFingerprintingwas set totrue. Need a workaround for this.