This repository has been archived by the owner on Nov 7, 2022. It is now read-only.
[WIP] New build scripts #104
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use and maintain separate directories for different architecture * Add watch scripts * zip scripts is not working for now
|
This looks like really promising. Just a heads up. The "npm run build" commands start by calling "npm run clean" which deletes the "dist" directory containing the generated extension files. Deleting dist before every build is a hack I made early on to ensure no stale files were accidentally kept. It's worthwhile to modify the build commands so that dist isn't deleted on every build. This will make incremental builds MUCH faster and make watch mode possible. It's also worthwhile looking into web-ext. |
|
web-ext sound good but no output_filename support. mozilla/web-ext#855 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes PR #103.
Goal:
watchscripts.Issues:
zipscripts is not working for now, I tried to solve it but encountered a few of problems. I hope this can be clearer, but I don't know how to do this. For example adding a helper.js to parse the parameters thus reduce the npm'sscripts.