-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
link iconv library on macOS #5
Conversation
I am also experiencing issues on Darwin, I've managed to get
|
I presume this is related to #6, and may even fix it. Is anybody with a macOS machine around willing to test this and se where we are at? |
a quick test on
This PR:
|
Thanks. That's kind of interesting but I think the main difference between master and this PR is just which rockspec is considered current. We don't even have a dev rockspec in here yet to realistically test from Git HEAD! I guess the short story is macOS is still broken and it's waiting for somebody to fix it. |
created #12 which adds a dev rockspec that includes this fix for mac. The error above was not a problem with the lib, but an expected error since the requested conversion apparently is not supported. The PR #12 also adds an errorcode as return value to the That would allow us to publish a new rock, as 7.1, with that fix, and a new version number to overcome the LuaRocks issue with the numbers. |
also means we shouldn't merge this PR, since it modifies a rockspec, which shouldn't happen, we should only create new ones (unless its a dev rockspec) |
can anyone review the #12 PR, so we can close this? |
#12 was merged, so we can close this now. |
current rockspec creates an .so not linked with libiconv which whilst it builds, cannot be used; have added library definition to the rockspec for both cygwin and macosx (possibly other platforms e.g. freebsd may also need; at least some flavours of linux don't need it)