Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release 7.1.0 #13

Merged
merged 1 commit into from
Oct 30, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
# Changelog

### 7.1.0 released 30-Oct-2023

* fix: rockspecs for MacOS

* feat: `iconv.new` now returns a second value in case of errors

---

### 7.0.0 released 17-Oct-2023

* First release from its new Lunar Modules home
25 changes: 15 additions & 10 deletions lua-iconv-dev-1.rockspec
Original file line number Diff line number Diff line change
@@ -1,22 +1,27 @@
-- Packs lua-iconv into a LuaRock
-- rockspec based uppon the file provided by DarkGod <darkgod at net-core.org>
local package_name = "lua-iconv"
local package_version = "dev"
local rockspec_revision = "1"
local github_account_name = "lunarmodules"
local github_repo_name = package_name

package = "lua-iconv"
version = "dev-1"
package = package_name
version = package_version.."-"..rockspec_revision

source = {
url = "git+https://github.com/lunarmodules/lua-iconv",
url = "git+https://github.com/"..github_account_name.."/"..github_repo_name..".git",
branch = (package_version == "dev") and "master" or nil,
tag = (package_version ~= "dev") and ("v" .. package_version) or nil,
}

description = {
summary = "Lua binding to the iconv",
detailed = [[
Lua binding to the POSIX 'iconv' library, which converts a sequence of
characters from one codeset into a sequence of corresponding characters
in another codeset.
]],
Lua binding to the POSIX 'iconv' library, which converts a sequence of
characters from one codeset into a sequence of corresponding characters
in another codeset.
]],
license = "MIT/X11",
homepage = "https://github.com/lunarmodules/lua-iconv/"
homepage = "https://github.com/"..github_account_name.."/"..github_repo_name,
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is that generated ? I find this needlessly obscure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

most of the lunar modules projects have this. I find it easier to manage since all essential metadata is at the top of the file now. (had too many cases of editing one but forgetting another occurrence).

Anyway, I do get your point, so let me know if the above doesn't change your mind, then I'll update it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sometimes I like to open these uris from my editor, and this kind of interpolation breaks that. Overall I think this parameterization makes the rockspec harder to read and because it's generated, everything could be hardcoded instead.
But it's a minor annoyance, dont bother. Let's use the general workflow.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I run into this a lot with distro packaging, especially in Arch Linux where package manifests are bash scripts and anything may be interpreted. I have some editor functions setup to do things like "open the homepage for this package" that process the language and use the output. For example in VIM, this can be done for almost any rockspec, including this one, like so:

:!sh -c "lua -e 'dofile [[%]] print(description.homepage)' | xdg-open"

Obviously the nested quoting is tricky, but with Lua's extra quote types at hand and VIM expanding the % to the current buffer filename, this command when run while editing a rockspec will send the home page to my browser. I have it wrapped in a command that does different things for different file types, but it means I don't have to worry about all URLs being spelled out with no variables in them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice tip, though the approach may scare contributors away.


dependencies = {
Expand Down
62 changes: 62 additions & 0 deletions rockspecs/lua-iconv-7.1.0-1.rockspec
Original file line number Diff line number Diff line change
@@ -0,0 +1,62 @@
local package_name = "lua-iconv"
local package_version = "7.1.0"
local rockspec_revision = "1"
local github_account_name = "lunarmodules"
local github_repo_name = package_name

package = package_name
version = package_version.."-"..rockspec_revision

source = {
url = "git+https://github.com/"..github_account_name.."/"..github_repo_name..".git",
branch = (package_version == "dev") and "master" or nil,
tag = (package_version ~= "dev") and ("v" .. package_version) or nil,
}

description = {
summary = "Lua binding to the iconv",
detailed = [[
Lua binding to the POSIX 'iconv' library, which converts a sequence of
characters from one codeset into a sequence of corresponding characters
in another codeset.
]],
license = "MIT/X11",
homepage = "https://github.com/"..github_account_name.."/"..github_repo_name,
}

dependencies = {
"lua >= 5.1",
}

external_dependencies = {
ICONV = {
header = "iconv.h"
}
}

build = {
type = "builtin",
modules = {
iconv = {
sources = {"luaiconv.c"},
incdirs = {"$(ICONV_INCDIR)"},
libdirs = {"$(ICONV_LIBDIR)"}
}
},
platforms = {
cygwin = {
modules = {
iconv = {
libraries = {"iconv"}
}
}
},
macosx = {
modules = {
iconv = {
libraries = {"iconv"}
}
}
},
}
}
Loading