Update rockspec post migration, modernize and lint #332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alerque
changed the title
alerque
force-pushed
the
rockspec-version
branch
from
152a3b6 to
7447068
Compare
Tieske
approved these changes
Oct 3, 2020
the |
|
Sure, I'll check it out. |
AntumDeluge
pushed a commit
to AntumDeluge/LDoc
that referenced
this pull request
Aug 1, 2021
Related lunarmodules#332. Add doc-site target to make file and yml file to build the docs. Following domenic's guide [1] but using leafo's gh actions like luacheck.yml. Builds the documentation for ldoc using the checked out version of ldoc and uses peaceiris/actions-gh-pages to publish. Once merged, docs will be available on https://lunarmodules.github.io/LDoc [1]: https://gist.github.com/domenic/ec8b0fc8ab45f39403dd
AntumDeluge
pushed a commit
to AntumDeluge/LDoc
that referenced
this pull request
Aug 2, 2021
Related lunarmodules#332. Add doc-site target to make file and yml file to build the docs. Following domenic's guide [1] but using leafo's gh actions like luacheck.yml. Builds the documentation for ldoc using the checked out version of ldoc and uses peaceiris/actions-gh-pages to publish. Once merged, docs will be available on https://lunarmodules.github.io/LDoc [1]: https://gist.github.com/domenic/ec8b0fc8ab45f39403dd
|
I think the docs should probably moved to a branch not a different directory. In any case I plan to deal with that in another PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to lunarmodules/Penlight#357 but in this case motivated by obsolete URLs.
@Tieske Do we have a plan to get the documentation URL migrated as well? I changed it in the rockspec here but it isn't actually live yet.