Upgrade to Gradle 8.13 & Java 21 (LTS)#412
Closed
notjuanortiz wants to merge 8 commits intoluna-rs:masterfrom
Closed
Upgrade to Gradle 8.13 & Java 21 (LTS)#412notjuanortiz wants to merge 8 commits intoluna-rs:masterfrom
notjuanortiz wants to merge 8 commits intoluna-rs:masterfrom
Conversation
Gradle version(5.6x -> 8.13) Kotlin version (1.4x -> 2.1.20) Java version (11 -> 23)
… to inWholeMilliseconds
This was needed for the kotlin upgrade.
notjuanortiz
changed the title
Plugins are being loaded from the source root now 'src/kotlin' so this isn't needed anymore. With Kotlin 1.9, scripts will no longer load from the source root,so I'm enabling the old behavior to save us time from having to move the plugin directory again.
notjuanortiz
changed the title
Contributor
Author
|
Kotlin scripts located inside the source root (/src/main/kotlin) are no longer supported by IntelliJ. I haven't come up with a solution for that issue yet but this branch is still works as is. |
notjuanortiz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Luna project!
Proposed changes
It's been years since we've done any large dependency upgrades so I figured we at least get access to some newer Java features.
Gradle also gets a big upgrade (v8.13) and so does Kotlin (v2.1.20)
Pull Request type
What types of changes does your code introduce to Luna?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Further comments