fix: flatten choice struct members within sequences #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The PubChem PUG View schema[1] frequently uses the following pattern:
```xml
<!-- ... -->
<xs:complexType>
<xs:sequence>
<xs:choice>
<xs:element name="A" type="xs:string"/>
<xs:element name="B" type="xs:int"/>
</xs:choice>
<xs:element name="..." type="xs:string" minOccurs="0"/>
</xs:sequence>
</xs:complexType>
</xs:element>
<!-- ... -->
```
Prior to this change the `xs:choice` element was being treated as just
another xsd element rather than a choice. This commit correctly tags enum
struct fields so that they are properly flattened.
[1]: https://pubchem.ncbi.nlm.nih.gov/docs/pug-view#section=Formats
adrienthebo
force-pushed
the
alt/sequence-choice
branch
from
7f35d76
to
9842ba7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PubChem PUG View schema1 frequently uses the following pattern:
Prior to this change the
xs:choiceelement was being treated as just another xsd element rather than a choice. This commit correctly tags enum struct fields so that they are properly flattened.