Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change: resolve fetch text to response.data #41

Closed

Conversation

saibotsivad
Copy link

Proposed solution for #40

I've been rolling with this version a bit and it seems correct so far.

@lukeed
Copy link
Owner

lukeed commented Feb 24, 2022

It’s only correct for non binary data. For example, it’ll break when fetching an image asset.

This needs a full body detector, like in worktop, or to expose the raw response (consistently), since here you do get the response for your text-based response and can call .text() yourself

@saibotsivad
Copy link
Author

Ah yeah, I see what you mean. In the Node version the concat works even on binary data. I'll close this PR then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants