Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abort request on timeout #17

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Abort request on timeout #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
156e83c
Abort request on timeout
roblav96 May 13, 2019
82e3b5c
Added tests for Request timed out
roblav96 May 13, 2019
bc04b2b
Update index.js
roblav96 May 13, 2019
fc34d3f
Update index.js
roblav96 May 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,11 @@ export function send(method, uri, opts={}) {
});
});

req.on('timeout', () => {
req.abort();
rej(new Error('Request timed out'));
});

req.on('error', rej);

if (opts.body) {
Expand Down
8 changes: 8 additions & 0 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,3 +210,11 @@ test('Error: Invalid JSON', async t => {
ctx.close();
});
});

test('Error: Request timed out', async t => {
t.plan(7);
await httpie.get('https://reqres.in/api/any', { timeout: 1 }).catch(err => {
t.true(err instanceof Error, '~> caught Request timed out');
t.true(err.message.includes('Request timed out'), '~> had "Request timed out" message');
});
});